netdev - Re: [TG3]: Fix link problem on Dell's onboard 5906.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070531.145024.52169518.davem@davemloft.net>
Date:	Thu, 31 May 2007 14:50:24 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mchan@...adcom.com
Cc:	netdev@...r.kernel.org
Subject: Re: [TG3]: Fix link problem on Dell's onboard 5906.

From: "Michael Chan" <mchan@...adcom.com>
Date: Thu, 31 May 2007 15:03:39 -0700

> [TG3]: Fix link problem on Dell's onboard 5906.
> 
> The bug is caused by code that always set
> (TG3_FLAG_USE_MI_INTERRUPT | TG3_FLAG_USE_LINKCHG_REG) on all Dell's
> onboard devices.  With these 2 flags set, the link status is polled
> by tg3_timer() and will only work when the PHY is set up to interrupt
> the MAC on link changes.  This breaks 5906 because the 5906 PHY does
> not support TG3_FLAG_USE_MI_INTERRUPT the same as other PHYs.
> 
> For correctness, only Dell's onboard 5701 needs these 2 flags to be
> set.  This change will fix the 5906 problem and will change other
> Dell devices except 5700 and 5701 to use the more efficient
> interrupt-driven link changes.
> 
> Update version to 3.77.
> 
> Signed-off-by: Michael Chan <mchan@...adcom.com>

Patch applied, thanks for fixing this bug Michael.

That Dell onboard chip logic is definitely my fault :)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html