[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20070531.154347.24896889.davem@davemloft.net>
Date: Thu, 31 May 2007 15:43:47 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: mark@...nes.org
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH] use default 32768-61000 outgoing port range in all
cases
From: Mark Glines <mark@...nes.org>
Date: Tue, 15 May 2007 15:50:54 -0700
> I noticed I had chopped off a whole comment, when I meant to only remove
> part of it. So I've fixed that.
>
> This is a reissued use-high-ports-for-local-stuff.diff, with a comment
> fix. Does anyone have a problem with this patch in its current form?
> Any chance of applying it?
>
> This diff changes the default port range used for outgoing connections,
> from "use 32768-61000 in most cases, but use N-4999 on small boxes
> (where N is a multiple of 1024, depending on just *how* small the box
> is)" to just "use 32768-61000 in all cases".
>
> I don't believe there are any drawbacks to this change, and it keeps
> outgoing connection ports farther away from the mess of IANA-registered
> ports.
>
> Signed-off-by: Mark Glines <mark@...nes.org>
Sorry for taking forever to wrap my brain around this, I think your
patch is the way to go and I will merge it.
The code was trying to match the allowed port range with the sizing
of the bind hash table, which is hashed by local port number. But
even considering that I think it's OK to use the full range by
default, always.
Thanks a lot.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists