netdev - bond_3ad.c: why does bond_3ad_set_carrier() check if the mac partnet mac is set.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <97949e3e0705311846x65ba3eacjb11e68ba38e1ed38@mail.gmail.com>
Date:	Thu, 31 May 2007 18:46:42 -0700
From:	"Laurent Chavey" <chavey@...gle.com>
To:	netdev@...r.kernel.org
Subject: bond_3ad.c: why does bond_3ad_set_carrier() check if the mac partnet mac is set.

if a host configured with 802.3ad bond mode is connected to a switch
that does not support 802.3ad,  then an aggregator is selected as the
active aggregator (first link that has carrier in the slave list).
This is perfectly fine, since it lets at least one of the link become active.
(this was the behavior prior to 2.6.18)

In 2.6.18 and above, a new check for the partner mac address was added
before an aggregator's carrier is set on. If a host is  configured as
previously
described,  then no links will become active.

is that the intended behavior ?

-----
in the scenario described here, the partner mac address is always set to NULL.
so the statement is always false.

	if (agg && MAC_ADDRESS_COMPARE(&agg->partner_system, &null_mac_addr)) {
		if (!netif_carrier_ok(bond->dev)) {
			netif_carrier_on(bond->dev);
			return 1;
		}
		return 0;
	}
----
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html