lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 1 Jun 2007 09:33:42 -0700 From: "Laurent Chavey" <chavey@...gle.com> To: netdev@...r.kernel.org Subject: [PATCH]: bonding: Fix 802.3ad no carrier on "no partner found" instance %diff -ru linux-2.6.21.3/drivers/net/bonding/bond_3ad.c linux-2.6.21.3.new/drivers/net/bonding/bond_3ad.c --- linux-2.6.21.3/drivers/net/bonding/bond_3ad.c 2007-05-24 14:22:47.000000000 -0700 +++ linux-2.6.21.3.new/drivers/net/bonding/bond_3ad.c 2007-06-01 09:28:07.000000000 -0700 @@ -2312,10 +2312,7 @@ */ int bond_3ad_set_carrier(struct bonding *bond) { - struct aggregator *agg; - - agg = __get_active_agg(&(SLAVE_AD_INFO(bond->first_slave).aggregator)); - if (agg && MAC_ADDRESS_COMPARE(&agg->partner_system, &null_mac_addr)) { + if (__get_active_agg(&(SLAVE_AD_INFO(bond->first_slave).aggregator))) { if (!netif_carrier_ok(bond->dev)) { netif_carrier_on(bond->dev); return 1; On 5/31/07, Laurent Chavey <chavey@...gle.com> wrote: > if a host configured with 802.3ad bond mode is connected to a switch > that does not support 802.3ad, then an aggregator is selected as the > active aggregator (first link that has carrier in the slave list). > This is perfectly fine, since it lets at least one of the link become active. > (this was the behavior prior to 2.6.18) > > In 2.6.18 and above, a new check for the partner mac address was added > before an aggregator's carrier is set on. If a host is configured as > previously > described, then no links will become active. > > is that the intended behavior ? > > > ----- > in the scenario described here, the partner mac address is always set to NULL. > so the statement is always false. > > if (agg && MAC_ADDRESS_COMPARE(&agg->partner_system, &null_mac_addr)) { > if (!netif_carrier_ok(bond->dev)) { > netif_carrier_on(bond->dev); > return 1; > } > return 0; > } > ---- > - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists