lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <46609A15.4000805@intel.com> Date: Fri, 01 Jun 2007 15:13:41 -0700 From: "Kok, Auke" <auke-jan.h.kok@...el.com> To: Jeff Garzik <jgarzik@...ox.com> CC: David Acker <dacker@...net.com>, Milton Miller <miltonm@....com>, "Kok, Auke" <auke-jan.h.kok@...el.com>, e1000-devel@...ts.sourceforge.net, Jeff Kirsher <jeffrey.t.kirsher@...el.com>, John Ronciak <john.ronciak@...el.com>, Jesse Brandeburg <jesse.brandeburg@...el.com>, Scott Feldman <sfeldma@...ox.com>, netdev@...r.kernel.org Subject: Re: [PATCH] fix e100 rx path on ARM (was [PATCH] e100 rx: or s and el bits) Jeff Garzik wrote: > David Acker wrote: >> Milton Miller wrote: <snip> >> the el flag but we leave the size was 0 bit set. This was we can find >> this buffer again later. >> >> If the hardware sees the el-bit cleared without the size set, it will >> move on to the next buffer and skip this one. If it sees >> the size set but the el-bit still set, it will complete that buffer >> and then RNR interrupt and wait. >> >> >> Signed-off-by: David Acker <dacker@...net.com> > > That seems to vaguely match my memory of what eepro100 was doing (or > trying to do). > > I _really_ appreciate you working on this problem. Getting e100 driver > stable for the long term, and ditching eepro100, is a big hurdle to > cross. Getting this right is really one of the last steps. yes, absolutely agreed. I'm very pleased with the attention and hope that is clear to everyone. > The patch looks OK at quick glance. Besides copying the style errors, it looks OK as well. I will attempt to allocate some testing time again early next week on a small library of e100 nics over here. Mostly x86, but still useful to spot obvious mistakes. Auke - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists