netdev - Re: [PATCH] spidernet: checksum and ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070601230612.GO7298@austin.ibm.com>
Date:	Fri, 1 Jun 2007 18:06:12 -0500
From:	linas@...tin.ibm.com (Linas Vepstas)
To:	Stephen Hemminger <shemminger@...ux-foundation.org>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] spidernet: checksum and ethtool

On Tue, May 29, 2007 at 05:24:36PM -0700, Stephen Hemminger wrote:
> It doesn't look like spidernet hardware can really checksum all protocols,
> the code looks like it does IPV4 only.  If so, it should use NETIF_F_IP_CSUM
> instead of NETIF_F_HW_CSUM.
> 
> The driver doesn't need it's own get/set for ethtool tx csum, and it
> should use the standard ethtool_op_get_link.
> 
> NOT TESTED (no CELL hardware).

It seems to work. I've been distracted with other spidernet issues;
I will forward your patch upstream early next week.

--linas
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html