lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: 04 Jun 2007 14:17:25 +0200 From: Urs Thuermann <urs@...ogud.escape.de> To: Oliver Hartkopp <socketcan@...tkopp.net> Cc: Patrick McHardy <kaber@...sh.net>, David Miller <davem@...emloft.net>, Thomas Gleixner <tglx@...utronix.de>, Oliver Hartkopp <oliver.hartkopp@...kswagen.de>, netdev@...r.kernel.org Subject: Re: [patch 5/7] CAN: Add virtual CAN netdevice driver Oliver Hartkopp <socketcan@...tkopp.net> writes: > 2. The loopback indication is done by using the unused skb->protocol in > the tx path. I don't think we should (mis-)use skb->protocol as a loopback flag. As the name says, it's the protocol number and not a flag whether loopback is to be done by the driver. Even if it's not used otherwise in tx path (haven't checked this), in my experience it is asking for future trouble to use variables other than for it's intended purpose. IMO it would be better to skb->pkt_type. This is used to indicate packet type to rcv functions registered by dev_add_pack(). It is set by netdevice drivers to PACKET_{MULTICAST,BROADCAST,HOST,OTHER} for received packets. In the send path it is set to PACKET_OUTGOING on the copy of the skbuff that is delivered to the sockets registered on ptype_all (typically packet sockets from tcpdump or other sniffers). AFAICS, pkt_type is not used otherwise in the send path. We could set skb->pkt_type = PACKET_LOOPBACK to flag to the CAN netdevice driver whether to loop back the packet. Any objections? urs - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists