netdev - doubt about qla3xxx checksum "fix"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070603.180051.89019554.davem@davemloft.net>
Date:	Sun, 03 Jun 2007 18:00:51 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	netdev@...r.kernel.org
CC:	shemminger@...ux-foundation.org, jeff@...zik.org
Subject: doubt about qla3xxx checksum "fix"

I don't think it's %100 right, I'm referring specifically to

e68a8c10c4c5daf363e946d10c1a5cba77d7f92c

Sure, qla3xxx is only handling ipv4 in that ql_hw_csum_setup()
function, but if you check the call site it really wants
CHECKSUM_PARTIAL skb's to work on.  And CHECKSUM_PARTIAL skbs are only
setup for paths that advertise the NETIF_F_HW_CSUM capability.

With Stephen's change it now won't checksum offload anything at all.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html