netdev - Re: [RFC][PATCH] Add suspend and resume support to uli526x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1180997344.4356.74.camel@nigel.suspend2.net>
Date:	Tue, 05 Jun 2007 08:49:04 +1000
From:	Nigel Cunningham <nigel@...el.suspend2.net>
To:	Pavel Machek <pavel@....cz>
Cc:	"Rafael J. Wysocki" <rjw@...k.pl>,
	linux-pm <linux-pm@...ts.osdl.org>, netdev@...r.kernel.org,
	Valerie Henson <val@....edu>, Peer Chen <peer.chen@....com.tw>
Subject: Re: [RFC][PATCH] Add suspend and resume support to uli526x

Hi.

On Tue, 2007-06-05 at 00:41 +0200, Pavel Machek wrote:
> Hi!
> 
> > > > > +#endif /* CONFIG_PM */
> > > > 
> > > > > @@ -1689,6 +1775,10 @@ static struct pci_driver uli526x_driver 
> > > > >  	.id_table	= uli526x_pci_tbl,
> > > > >  	.probe		= uli526x_init_one,
> > > > >  	.remove		= __devexit_p(uli526x_remove_one),
> > > > > +#ifdef CONFIG_PM
> > > > > +	.suspend	= uli526x_suspend,
> > > > > +	.resume		= uli526x_resume,
> > > > > +#endif
> > > > 
> > > > ...so that this ifdef is not needed?
> > > 
> > > OK, why not.
> > 
> > Because it's uglier and #ifdef is the established way of doing things?
> 
> Actually the way I suggested is nicer, IIRC akpm invented it. It keeps
> ifdefs localized around the block that _needs_ to be ifdefed.

The localised point is true. I'll also admit that 'nicer'/'uglier' is a
matter of aesthetics and therefore personal opinion.

I guess that leaves the question, "What's the precedent to follow?" or
"Is there a driver that's already got this new format?".

Regards,

Nigel

Download attachment "signature.asc" of type "application/pgp-signature" (190 bytes)