netdev - Re: [PATCH] tcp_probe: __attribute_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 6 Jun 2007 15:15:30 +1200
From:	"Ian McDonald" <ian.mcdonald@...di.co.nz>
To:	"David Miller" <davem@...emloft.net>
Cc:	randy.dunlap@...cle.com, netdev@...r.kernel.org,
	"Arnaldo Carvalho de Melo" <acme@...stprotocols.net>,
	"Patrick Andrieux" <patrick.andrieux@...il.com>
Subject: Re: [PATCH] tcp_probe: __attribute__ string location

On 6/6/07, David Miller <davem@...emloft.net> wrote:
> From: Randy Dunlap <randy.dunlap@...cle.com>
> Date: Tue, 5 Jun 2007 18:01:41 -0700
>
> > From: Randy Dunlap <randy.dunlap@...cle.com>
> >
> > gcc doesn't like the location of the __attribute__ string here:
> > net/ipv4/tcp_probe.c:83: warning: empty declaration
> >
> > so move it to before the function and all is well.
> >
> > Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
>
> Yeah I noticed this one too and a similar fix is in
> my net-2.6 GIT tree, but thanks anyways Randy.

I'm wondering if either of you can actually load tcp_probe at present.
We had reports on dccp mailing list that dccp_probe and tcp_probe
can't load at present and produce a back trace. It appears related to
the jprobe stuff according to Arnaldo.

If the bug reporter or Arnaldo doesn't follow up on it I'll track it
down a little more later and post to correct place.

I'll also copy this change across to DCCP at sometime as well as
several others that we haven't transferred across as well.

Ian
-- 
Web: http://wand.net.nz/~iam4/
Blog: http://iansblog.jandi.co.nz
WAND Network Research Group
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html