netdev - Re: [PATCH] NET: Multiqueue network device support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 8 Jun 2007 22:37:35 +1000
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	jamal <hadi@...erus.ca>
Cc:	Sridhar Samudrala <sri@...ibm.com>,
	David Miller <davem@...emloft.net>, auke-jan.h.kok@...el.com,
	jeff@...zik.org, kaber@...sh.net, peter.p.waskiewicz.jr@...el.com,
	netdev@...r.kernel.org, jesse.brandeburg@...el.com
Subject: Re: [PATCH] NET: Multiqueue network device support.

On Fri, Jun 08, 2007 at 07:34:57AM -0400, jamal wrote:
> On Fri, 2007-08-06 at 20:39 +1000, Herbert Xu wrote:
> 
> > It would guard against the poll routine which would acquire this lock
> > when cleaning the TX ring.
> 
> Ok, then i suppose we can conclude it is a bug on e1000 (holds tx_lock
> on tx side and adapter queue lock on rx). Adding that lock will
> certainly bring down the performance numbers on a send/recv profile.
> The bizare thing is things run just fine even under the heavy tx/rx
> traffic i was testing under. I guess i didnt hit hard enough.

Hmm I wasn't describing how it works now.  I'm talking about how it
would work if we removed LLTX and replaced the private tx_lock with
netif_tx_lock.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html