netdev - Re: [PATCH 3/4] NetXen: Add correct routines to setup multicast address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200706101159.25756.mb@bu3sch.de>
Date:	Sun, 10 Jun 2007 11:59:25 +0200
From:	Michael Buesch <mb@...sch.de>
To:	Mithlesh Thukral <mithlesh@...xen.com>
Cc:	netdev@...r.kernel.org, amitkale@...xen.com, jeff@...zik.org,
	netxenproj@...syssoft.com, rob@...xen.com
Subject: Re: [PATCH 3/4] NetXen: Add correct routines to setup multicast address

On Sunday 10 June 2007 11:54:11 Michael Buesch wrote:
> > +int netxen_nic_set_mcast_addr(struct netxen_adapter *adapter, int index, 
> > +				u8 *addr)
> > +{
> > +	u32 hi = 0;
> > +	u32 lo = 0;
> > +	u16 port = physical_port[adapter->portnum];
> > +
> > +	hi = (u32) addr[0] | 
> > +		((u32) addr[1] << 8) |
> > +		((u32) addr[2] << 16);
> > +	lo = (u32) addr[3] |
> > +		((u32) addr[4] << 8) |
> > +		((u32) addr[5] << 16);
> 
> That is the correct solution. Do that above, too.
> 
> > +	netxen_crb_writelit_adapter(adapter, NETXEN_MCAST_ADDR(port,index), hi);
> > +	netxen_crb_writelit_adapter(adapter, NETXEN_MCAST_ADDR(port,index) + 4,
> > +					hi);
> > +	return 0;
> > +}

Well, actually no. It is broken, too. You write hi twice. And I would
swap the variable names, as "low" is addr[0] in my understanding.



-- 
Greetings Michael.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html