lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 11 Jun 2007 10:00:53 +0200 From: Jens Axboe <jens.axboe@...cle.com> To: Evgeniy Polyakov <johnpol@....mipt.ru> Cc: David Miller <davem@...emloft.net>, netdev@...r.kernel.org Subject: Re: [PATCH][RFC] network splice receive On Fri, Jun 08 2007, Evgeniy Polyakov wrote: > Size of the received file is bigger than file sent, file contains repeated > blocks of data sometimes. Cloned skb usage is likely too big overhead, > although for receiving fast clone is unused in most cases, so there > might be some gain. That was actually a new bug, here: plen -= *offset; poff += *offset; in __skb_slice_bits(), we should only subtract the offset from plen, not add to poff. Then we just create some weird hole without any meaning. So remove those two poff additions in the two loops, and the size issue is resolved at least. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists