lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <D5C1322C3E673F459512FB59E0DDC3290303AAE8@orsmsx414.amr.corp.intel.com> Date: Mon, 11 Jun 2007 10:57:20 -0700 From: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com> To: "Patrick McHardy" <kaber@...sh.net> Cc: <davem@...emloft.net>, <netdev@...r.kernel.org>, <jeff@...zik.org>, "Kok, Auke-jan H" <auke-jan.h.kok@...el.com> Subject: RE: [PATCH] NET: Multiqueue network device support. > PJ Waskiewicz wrote: > > diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index > > e7367c7..8bcd870 100644 > > --- a/include/linux/skbuff.h > > +++ b/include/linux/skbuff.h > > @@ -215,6 +215,7 @@ typedef unsigned char *sk_buff_data_t; > > * @pkt_type: Packet class > > * @fclone: skbuff clone status > > * @ip_summed: Driver fed us an IP checksum > > + * @queue_mapping: Queue mapping for multiqueue devices > > * @priority: Packet queueing priority > > * @users: User count - see {datagram,tcp}.c > > * @protocol: Packet protocol from driver > > @@ -269,6 +270,7 @@ struct sk_buff { > > __u16 csum_offset; > > }; > > }; > > + __u16 queue_mapping; > > __u32 priority; > > __u8 local_df:1, > > cloned:1, > > > I think we can reuse skb->priority. Assuming only real > hardware devices use multiqueue support, there should be no user of > skb->priority after egress qdisc classification. The only reason > to preserve it in the qdisc layer is for software devices. That would be oustanding. > Grepping through drivers/net shows a few users, bot most seem > to be using it on the RX path and some use it to store internal data. Thank you for hunting this down. I will test on my little environment here to see if I run into any issues. -PJ - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists