netdev - Re: [PATCH 1/2] [RFC] NET: Implement a standard ndev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Jun 2007 11:28:12 -0700
From:	Joe Perches <joe@...ches.com>
To:	Stephen Hemminger <shemminger@...ux-foundation.org>
Cc:	"Kok, Auke" <auke-jan.h.kok@...el.com>, netdev@...r.kernel.org,
	jeff@...zik.org, davem@...emloft.net, arjan@...ux.intel.com
Subject: Re: [PATCH 1/2] [RFC] NET: Implement a standard ndev_printk family

I like the ndev_printk idea.

I think a ndev_<level> printks should take a const netdev*
as the first argument.

Also, better for the non-debug use of ndev_dbg is to have a
static inline function so printf args are verified.

For instance, dev_dbg does:

static inline int __attribute__ ((format (printf, 2, 3)))
dev_dbg(struct device * dev, const char * fmt, ...)
{
        return 0;
}

Perhaps ndev_dbg should look like this:

static inline int __attribute ((format (printf, 3, 4)))
__ndev_dbg(const struct net_device *netdev, u32 level, const char *format, ...)
{
	return 0;
}

#define ndev_dbg(netdev, level, fmt, args...) \
	__ndev_dbg(netdev, NETIF_MSG_##level, fmt, ##args)



-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html