netdev - Re: [2.6 patch] net/sunrpc/rpcb_clnt.c: make struct rpcb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <466F28E8.3010101@oracle.com>
Date:	Tue, 12 Jun 2007 19:14:48 -0400
From:	Chuck Lever <chuck.lever@...cle.com>
To:	Adrian Bunk <bunk@...sta.de>
CC:	Trond Myklebust <Trond.Myklebust@...app.com>,
	netdev@...r.kernel.org
Subject: Re: [2.6 patch] net/sunrpc/rpcb_clnt.c: make struct rpcb_program
 static

Adrian Bunk wrote:
> This patch makes the needlessly global struct rpcb_program static.
> 
> Signed-off-by: Adrian Bunk <bunk@...sta.de>

Acked-by: Chuck Lever <chuck.lever@...cle.com>

> ---
> 
>  net/sunrpc/rpcb_clnt.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- linux-2.6.22-rc4-mm2/net/sunrpc/rpcb_clnt.c.old	2007-06-12 23:25:01.000000000 +0200
> +++ linux-2.6.22-rc4-mm2/net/sunrpc/rpcb_clnt.c	2007-06-12 23:25:19.000000000 +0200
> @@ -118,7 +118,7 @@
>  #define RPCB_MAXOWNERLEN	sizeof(RPCB_OWNER_STRING)
>  
>  static void			rpcb_getport_done(struct rpc_task *, void *);
> -extern struct rpc_program	rpcb_program;
> +static struct rpc_program	rpcb_program;
>  
>  struct rpcbind_args {
>  	struct rpc_xprt *	r_xprt;
> @@ -616,7 +616,7 @@
>  
>  static struct rpc_stat rpcb_stats;
>  
> -struct rpc_program rpcb_program = {
> +static struct rpc_program rpcb_program = {
>  	.name		= "rpcbind",
>  	.number		= RPCBIND_PROGRAM,
>  	.nrvers		= ARRAY_SIZE(rpcb_version),
> 


View attachment "chuck.lever.vcf" of type "text/x-vcard" (303 bytes)