netdev - Re: small forcedeth WoL fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <467055D2.4010205@garzik.org>
Date:	Wed, 13 Jun 2007 16:38:42 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Tim Mann <mann@...are.com>
CC:	netdev@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: small forcedeth WoL fix

Tim Mann wrote:
> I happened to notice that a system with an NVidia NIC using the
> forcedeth driver won't wake-on-LAN if the interface was in promiscuous
> mode when you power off.  By experiment, it looks like
> the hardware needs to have NvRegPacketFilterFlags set to
> NVREG_PFF_ALWAYS|NVREG_PFF_MYADDR (i.e., receive unicast packets to my
> address) in order for WoL to work.  At any rate, the attached patch
> fixes the problem for me.
> 
> 
> 
> ------------------------------------------------------------------------
> 
> --- forcedeth-git-netdev.c	2007-06-01 16:43:19.971507000 -0700
> +++ forcedeth-git-netdev-fixed.c	2007-06-01 16:46:53.389713000 -0700
> @@ -4830,8 +4830,10 @@
>  
>  	drain_ring(dev);
>  
> -	if (np->wolenabled)
> +	if (np->wolenabled) {
> +		writel(NVREG_PFF_ALWAYS|NVREG_PFF_MYADDR, base + NvRegPacketFilterFlags);
>  		nv_start_rx(dev);
> +	}

Please resend as a proper Linux patch[1], apply-able using "patch -sp1", 
and including a signed-off-by line.

NVIDIA says the patch looks OK.

	Jeff


[1] Documentation/SubmittingPatches or 
http://linux.yyz.us/patch-format.html
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html