netdev - Re: [Cbe-oss-dev] [PATCH 12/15] spidernet: increase the NAPI weight

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200706132249.51894.arnd@arndb.de>
Date:	Wed, 13 Jun 2007 22:49:51 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	cbe-oss-dev@...abs.org
Cc:	netdev@...r.kernel.org, Jeff Garzik <jeff@...zik.org>,
	Linas Vepstas <linas@...tin.ibm.com>
Subject: Re: [Cbe-oss-dev] [PATCH 12/15] spidernet: increase the NAPI weight

On Wednesday 13 June 2007, Jeff Garzik wrote:
> > +/* We really really want to empty the ring buffer every time,
> > + * so as to avoid the RX ram full bug. So set te napi wieght
> > + * to the ring size.
> > + */
> > +#define SPIDER_NET_NAPI_WEIGHT       SPIDER_NET_RX_DESCRIPTORS_DEFAULT
> 
> I don't see why spider_net should have a different NAPI weight from 
> other drivers
> 

Would it help to do it the other way round, as in

#define SPIDER_NET_RX_DESCRIPTORS_DEFAULT SPIDER_NET_NAPI_WEIGHT

and leave that at 64 instead of 256?

	Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html