netdev - Re: [ANNOUNCE] new driver ixgbe for Intel(R) 10GbE PCI Express adapters.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070613230513.GB22521@electric-eye.fr.zoreil.com>
Date:	Thu, 14 Jun 2007 01:05:13 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Ayyappan.Veeraiyan@...el.com
Cc:	netdev@...r.kernel.org, jeff@...zik.org, auke-jan.h.kok@...el.com,
	arjan@...ux.intel.com, akpm@...ux-foundation.org
Subject: Re: [ANNOUNCE] new driver ixgbe for Intel(R) 10GbE PCI Express adapters.

Ayyappan.Veeraiyan@...el.com <Ayyappan.Veeraiyan@...el.com> :
[...]
> Please review and provide comments.

o ixgbe_call_func and the ton of wrappers which go along with it
  should go.

o boolean_t duplicates the existing 'bool'

o The options below {should be/are} handled through ethtool:
  - TxDescriptors
  - RxDescriptors
  - XsumRX

o No __iomem annotations ?

o pci_alloc_consistent() returns a zeroed area: no need for memset.

o ixgbe_clean_tx_irq() is issued from the NAPI poll handler (as the
  name suggests...). Its locking will probably cause a deadlock if
  it is interrupted and a call to netpoll_send_skb follows.

-- 
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html