netdev - Re: [PATCH]: ps3: gigabit ethernet driver for PS3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070613160848.71DE.MOKUNO@sm.sony.co.jp>
Date:	Wed, 13 Jun 2007 17:48:44 +0900
From:	MOKUNO Masakazu <mokuno@...sony.co.jp>
To:	David Miller <davem@...emloft.net>
Cc:	jeff@...zik.org, netdev@...r.kernel.org,
	geoffrey.levand@...sony.com, Geert.Uytterhoeven@...ycom.com
Subject: Re: [PATCH]: ps3: gigabit ethernet driver for PS3

Hi David,

On Wed, 13 Jun 2007 00:03:59 -0700 (PDT)
David Miller <davem@...emloft.net> wrote:

> From: MOKUNO Masakazu <mokuno@...sony.co.jp>
> Date: Wed, 13 Jun 2007 15:58:01 +0900
> 
> > --- a/drivers/net/Makefile
> > +++ b/drivers/net/Makefile
> > @@ -60,6 +60,8 @@ obj-$(CONFIG_TIGON3) += tg3.o
> >  obj-$(CONFIG_BNX2) += bnx2.o
> >  spidernet-y += spider_net.o spider_net_ethtool.o
> >  obj-$(CONFIG_SPIDER_NET) += spidernet.o sungem_phy.o
> > +obj-$(CONFIG_GELIC_NET) += ps3_gelic.o
> > +ps3_gelic-objs += gelic_net.o
> >  obj-$(CONFIG_TC35815) += tc35815.o
> >  obj-$(CONFIG_SKGE) += skge.o
> >  obj-$(CONFIG_SKY2) += sky2.o
> 
> Please just name the driver ps3_galic.c and use a single
> 
> obj-$(CONFIG_GELIC_NET) += ps3_galic.o


I have plan to add wireless support as I sent to this ML before as RFC,
like:

> +config GELIC_WIRELESS
> +	bool "Gelic net Wireless Extension"
> +	depends on GELIC_NET
> +	select WIRELESS_EXT
> +	help
> +	  Wireless Extension support for Gelic Gigabit Ethernet driver
> +
>  config GIANFAR
>  	tristate "Gianfar Ethernet"
>  	depends on 85xx || 83xx || PPC_86xx
> --- a/drivers/net/Makefile
> +++ b/drivers/net/Makefile
> @@ -61,7 +61,8 @@ obj-$(CONFIG_BNX2) += bnx2.o
>  spidernet-y += spider_net.o spider_net_ethtool.o
>  obj-$(CONFIG_SPIDER_NET) += spidernet.o sungem_phy.o
>  obj-$(CONFIG_GELIC_NET) += ps3_gelic.o
> -ps3_gelic-objs += gelic_net.o
> +gelic-$(CONFIG_GELIC_WIRELESS) += gelic_wireless.o
> +ps3_gelic-objs += gelic_net.o $(gelic-y)
>  obj-$(CONFIG_TC35815) += tc35815.o
>  obj-$(CONFIG_SKGE) += skge.o
>  obj-$(CONFIG_SKY2) += sky2.o

That 'ps3_gelic' line change was made so that module file names can keep
consistent after the patch above applied.

Any ideas appreciated.

--
Masakazu MOKUNO

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html