netdev - Re: [ANNOUNCE] new driver ixgbe for Intel(R) 10GbE PCI Express adapters.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ae4a4a920706131706m6993e96bhdab638850b4769cf@mail.gmail.com>
Date:	Wed, 13 Jun 2007 17:06:57 -0700
From:	"Ayyappan Veeraiyan" <Ayyappan.Veeraiyan@...el.com>
To:	"Francois Romieu" <romieu@...zoreil.com>
Cc:	netdev@...r.kernel.org, jeff@...zik.org, auke-jan.h.kok@...el.com,
	arjan@...ux.intel.com, akpm@...ux-foundation.org
Subject: Re: [ANNOUNCE] new driver ixgbe for Intel(R) 10GbE PCI Express adapters.

On 6/13/07, Francois Romieu <romieu@...zoreil.com> wrote:

Please ignore my previous response. Forgot to reply_all..

>
> o ixgbe_clean_tx_irq() is issued from the NAPI poll handler (as the
>   name suggests...). Its locking will probably cause a deadlock if
>   it is interrupted and a call to netpoll_send_skb follows.
>

netpoll_send_skb should not deadlock because ixgbe_xmit_frame should
bail out because of this...

      if (!spin_trylock_irqsave(&tx_ring->tx_lock, flags))
               /* Collision - tell upper layer to requeue */
               return NETDEV_TX_LOCKED;

Right?

The LLTX and tx_lock handling in the driver is not clean and I am
working on to fix it. Also will make sure we are handling the net_poll
case correctly...

Thanks for the feedback..

Ayyappan
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html