netdev - [PATCH 2.6.22-rc4-git6] forcedeth: use unicast receive mode for WoL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070614131638.1a5cef4c@mann-lx.eng.vmware.com>
Date:	Thu, 14 Jun 2007 13:16:38 -0700
From:	Tim Mann <mann@...are.com>
To:	netdev@...r.kernel.org
Cc:	mann@...are.com, Andrew Morton <akpm@...ux-foundation.org>
Subject: [PATCH 2.6.22-rc4-git6] forcedeth: use unicast receive mode for WoL

I happened to notice that a system with an NVidia NIC using the
forcedeth driver won't wake-on-LAN if the interface was in promiscuous
mode when you power off.  By experiment, it looks like
the hardware needs to have NvRegPacketFilterFlags set to
NVREG_PFF_ALWAYS|NVREG_PFF_MYADDR (i.e., receive unicast packets to my
address) in order for WoL to work.

Jeff Garzik writes: "NVIDIA says the patch looks OK."  I didn't venture
to insert a signed-off-by line with his name on it, though.

Signed-off-by: Tim Mann <mann@...are.com>

---
(Jeff, thanks for pointing me to the doc for the proper patch format.)

--- 2.6.22-rc4-git6/drivers/net/forcedeth.c	2007-06-14 12:56:47.078002000 -0700
+++ 2.6.22-rc4-git6-fixed/drivers/net/forcedeth.c	2007-06-14 12:56:21.200146000 -0700
@@ -4825,8 +4825,10 @@

 	drain_ring(dev);

-	if (np->wolenabled)
+	if (np->wolenabled) {
+		writel(NVREG_PFF_ALWAYS|NVREG_PFF_MYADDR, base + NvRegPacketFilterFlags);
 		nv_start_rx(dev);
+	}

 	/* FIXME: power down nic */

-- 
Tim Mann  work: mann@...are.com  home: tim@...-mann.org
          http://www.vmware.com  http://tim-mann.org
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html