netdev - Re: [PATCH 4/15] spidernet: silence the ramfull messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070614222943.GY4397@austin.ibm.com>
Date:	Thu, 14 Jun 2007 17:29:43 -0500
From:	linas@...tin.ibm.com (Linas Vepstas)
To:	Jeff Garzik <jeff@...zik.org>
Cc:	Michael Ellerman <michael@...erman.id.au>, netdev@...r.kernel.org,
	cbe-oss-dev@...abs.org
Subject: Re: [PATCH 4/15] spidernet: silence the ramfull messages

On Wed, Jun 13, 2007 at 04:12:00PM -0400, Jeff Garzik wrote:
> Linas Vepstas wrote:
> >--- linux-2.6.22-rc1.orig/drivers/net/spider_net.c	2007-06-11 
> >10:02:34.000000000 -0500
> >+++ linux-2.6.22-rc1/drivers/net/spider_net.c	2007-06-11 
> >11:45:25.000000000 -0500
> >@@ -1172,7 +1172,7 @@ spider_net_decode_one_descr(struct spide
> > 		goto bad_desc;
> > 	}
> > 
> >-	if (hwdescr->dmac_cmd_status & 0xfefe) {
> >+	if (hwdescr->dmac_cmd_status & 0xfcf4) {
> > 		pr_err("%s: bad status, cmd_status=x%08x\n",
> > 			       card->netdev->name,
> > 			       hwdescr->dmac_cmd_status);
> 
> 
> A follow-up patch needs to remove the above magic numbers (==numeric 
> constants), replacing them with named constants

I thought laziness was a virtue ... oh, wait, wrong programming language.

Patch coming shortly.

--linas
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html