[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <C2987D7E.93CF%Keir.Fraser@cl.cam.ac.uk>
Date: Fri, 15 Jun 2007 17:31:42 +0100
From: Keir Fraser <Keir.Fraser@...cam.ac.uk>
To: Kieran Mansley <kmansley@...arflare.com>,
Zhu Han <schumi.han@...il.com>
CC: <netdev@...r.kernel.org>, <xen-devel@...ts.xensource.com>,
<herbert@...dor.apana.org.au>
Subject: Re: [Xen-devel] [PATCH 4/4] [Net] Support accelerated network
plugin modules
On 15/6/07 17:22, "Kieran Mansley" <kmansley@...arflare.com> wrote:
> The lock protects the use_count variable.
Yes, that's one thing I noticed -- can you use atomic_t for reference counts
and hence reduce the number of times you need to lock/unlock? At least the
open-coded lock-decrement-test-maybe-free-unlock sequences could be
abstracted into a put_foo() function.
-- Keir
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists