netdev - Re: [PATCH] b44-ssb: Fix IRQ routing bits on the backplane

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200706171721.56192.maxi@daemonizer.de>
Date:	Sun, 17 Jun 2007 17:21:53 +0200
From:	Maximilian Engelhardt <maxi@...monizer.de>
To:	Michael Buesch <mb@...sch.de>
Cc:	John Linville <linville@...driver.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	netdev@...r.kernel.org, Gary Zambrano <zambrano@...adcom.com>
Subject: Re: [PATCH] b44-ssb: Fix IRQ routing bits on the backplane

On Sunday 17 June 2007, Michael Buesch wrote:
> The backplane on the b44 chip seems to have a silicon bug
> in the IRQ routing. The ethernet core IRQ routing does not work
> with the routing bit returned from the backplaneflag register.
> This patch adds a workaround for the b44 chip to use a hardcoded
> constant. This constant was also used in the old b44 driver.
>
> Signed-off-by: Michael Buesch <mb@...sch.de>
> Cc: Maximilian Engelhardt <maxi@...monizer.de>
> Cc: Gary Zambrano <zambrano@...adcom.com>

Tested-by: Maximilian Engelhardt <maxi@...monizer.de>

>
> Index: bu3sch-wireless-dev/drivers/ssb/driver_pcicore.c
> ===================================================================
> --- bu3sch-wireless-dev.orig/drivers/ssb/driver_pcicore.c	2007-06-17
> 13:35:45.000000000 +0200 +++
> bu3sch-wireless-dev/drivers/ssb/driver_pcicore.c	2007-06-17
> 14:19:05.000000000 +0200 @@ -496,9 +496,15 @@ int
> ssb_pcicore_dev_irqvecs_enable(struc
>  		u32 intvec;
>
>  		intvec = ssb_read32(pdev, SSB_INTVEC);
> -		tmp = ssb_read32(dev, SSB_TPSFLAG);
> -		tmp &= SSB_TPSFLAG_BPFLAG;
> -		intvec |= tmp;
> +		if ((bus->chip_id & 0xFF00) == 0x4400) {
> +			/* Workaround: On the BCM44XX the BPFLAG routing
> +			 * bit is wrong. Use a hardcoded constant. */
> +			intvec |= 0x00000002;
> +		} else {
> +			tmp = ssb_read32(dev, SSB_TPSFLAG);
> +			tmp &= SSB_TPSFLAG_BPFLAG;
> +			intvec |= tmp;
> +		}
>  		ssb_write32(pdev, SSB_INTVEC, intvec);
>  	}
>
>
> Please apply this to wireless-dev.
> This is also most likely the bug Uwe Bugla was
> bullshitting about^W^Wreporting.

Maxi

Download attachment "signature.asc " of type "application/pgp-signature" (190 bytes)