Message-Id: <1182081831.23681.29.camel@johannes.berg>
Date:	Sun, 17 Jun 2007 14:03:51 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Michael Wu <flamingice@...rmilk.net>
Cc:	Zhu Yi <yi.zhu@...el.com>, linux-wireless@...r.kernel.org,
	"John W. Linville" <linville@...driver.com>,
	David Lamparter <lists@...c24.net>,
	Thomas Graf <tgraf@...g.ch>, netdev <netdev@...r.kernel.org>
Subject: wireless userspace MLME and generic netlink vs. multicast (was:
	Re: [Take 2] mac80211 IEEE802.11e/WMM code cleanup)

[if you haven't seen the rest of the thread skip down to the === mark]

On Sat, 2007-06-16 at 15:16 -0700, Michael Wu wrote:

> > I don't think the implementation details are much of a problem. It's
> > just a bit of message bouncing which is trivial. Except of course when
> > you consider wext, but hey, no need to consider that for this discussion
> > since you're proposing ditching wext completely. Not that I don't want
> > to ditch it, but people still use it and probably will. Heck, people
> > still use 'ifconfig'...
> >
> I'm not proposing to ditch wext completely. When did I say that?

You're saying that you want people to communicate directly with the
userspace MLME, so wext is out.

> It's a waste of time when nl80211 needs to be patched every time we want an 
> additional command in the userspace MLME.

I actually see this as a benefit, that way the API gets some review...
Also, if you want to use a userspace library, that library will need
patching everytime you need an additional MLME command; if you don't
have any formal API then of course you don't have that problem but that
also means that all the applications aren't able to interoperate
properly.

It sounds to me like you're proposing that wpa_supplicant is the only
supported userspace MLME and that wpa_cli is the only way to configure
it, basically. I sure hope that isn't so.

> I don't think the needs of a firmware based MLME are necessarily the same as a 
> userspace MLME. Some commands will certainly be the same, but just because 
> the commands are there doesn't mean it's good to make them work if you have 
> to fake it. The kernel should show what the hardware/stack can do and nothing 
> more.

No, you don't understand. Of course something should tell you what your
wireless connection can do. But if there's a userspace MLME used to
implement that wireless connection then that userspace MLME tells you
what it can do, which is fine.

Saying that it's not good to make commands work is like saying every
tiny hardware difference should get new API to perfectly match that
particular hardware instead of using common API to work with all
hardware in a unified way.

That's the goal here anyway, to work with hardware in a unified way. And
hopefully there'll be more userspace MLMEs rather than just
wpa_supplicant. There's xsupplicant too, maybe it'll have some support,
who knows.

[===]

Yes, talking with the userspace MLME via netlink is some form of IPC. In
fact, I just had this idea that instead of having the kernel bounce
messages to the userspace MLME we could instead have a MLME-multicast
group. The kernel listens on that multicast group and executes the
commands if no other program is listening on the group, and the
configuration programs simply multicast the configuration requests.
We'll have to sort out in userspace that we never have two MLMEs running
at the same time, but that is far less effort than trying to sort out
finding the MLME in userspace. It also lets us control the API.

At the same time, however, this doesn't seem to be implementable using
generic netlink right now because we cannot allow non-root users to
listen on the MLME-multicast group (this isn't actually possible for
normal netlink either right now because we need non-root users listening
on other groups, but that could be easily solved with a patch to give a
non-root group mask instead of a flag for the netlink code)

However, digging through the code it seems that generic netlink is a bit
weird with multicast anyway. Right now, what you do as a userspace
application is you ask for multicast on the generic netlink socket, but
you can then talk to multiple families. As far as I can tell that means
that you'll be receiving multicasts for ACPI events and for nl80211
events if they happen to use the same groups. I'd think that generic
netlink should be integrated a bit better and it should be possible to
sign up for groups within a family.

When then it also becomes possible to disallow certain groups for
non-root users, we should be able to solve the userspace MLME problem by
using a multicast group as above, I haven't tested it yet though.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (191 bytes)

Powered by blists - more mailing lists