lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 18 Jun 2007 14:04:11 -0700
From:	"Waskiewicz Jr, Peter P" <>
To:	"Patrick McHardy" <>
Cc:	<>, <>, <>,
	"Kok, Auke-jan H" <>, <>
Subject: RE: [PATCH 2/3] NET: [SCHED] Qdisc changes and sch_rr added for multiqueue

> > Hmm.  This is the sch_prio from the first 2.6.23-dev tree.  I'll 
> > resync and make sure it's the correct one.
> Current 2.6.22-rc and net-2.6.23 have
>         if (band >= q->bands)

I just pulled 2.6.23 down, and see that is true.  I must have had that
left over.  I'll fix that.

> > I'm not sure I understand what you mean here about nested 
> attributes.
> Nested netlink attributes, like most qdisc use, instead of 
> struct tc_rr_qopt (or additionally). The way you've done it 
> makes it hard to add further attributes later.

I'm going to need to think about this more, since I'm not immediately
getting what you're referring to.  I see the qdisc using tc_prio_qopt as
a single member; do you have an example outside of the qdiscs I can look
at and see what you're referring to?  Please bear with me: my netlink
skills are still very green.

> BTw, couldn't you just merge sch_rr with prio? AFAICT you 
> only need a new dequeue function, a new struct Qdisc_ops and 

Are you suggesting a module that can determine RR or PRIO at runtime?
Because the two are so similar, I definitely thought about combining
them, but because of the dequeue difference, you'd need a load-time
switch to determine which mode to run the module in.  That would break
ABI for sch_prio, which I was trying to avoid.

Thanks Patrick,
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists