netdev - Re: r8169 tx problem (1s pause with ping)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070619230641.GD14681@electric-eye.fr.zoreil.com>
Date:	Wed, 20 Jun 2007 01:06:41 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	David Gundersen <gundy@...et.net.au>
Cc:	netdev@...r.kernel.org, Benjamin LaHaise <bcrl@...ck.org>
Subject: Re: r8169 tx problem (1s pause with ping)

Francois Romieu <romieu@...zoreil.com> :
[...]
> A pesky fever apart, I should be able to come with a patch before
> the week end.

(oops, late again)

You can try the hack below as a temporary fix.

It makes things way better on top of 2.6.22-rc5 + current r8169 patchkit at
http://www.fr.zoreil.com/people/francois/misc/20070619-2.6.22-rc5-r8169-test.patch

It applies against 2.6.22-rc5 too.

I should come with something else soon.

diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index 8f3e0da..8c0851f 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -2682,6 +2688,8 @@ static void rtl8169_tx_interrupt(struct net_device *dev,
 		    (TX_BUFFS_AVAIL(tp) >= MAX_SKB_FRAGS)) {
 			netif_wake_queue(dev);
 		}
+		if (tp->dirty_tx != tp->cur_rx)
+			RTL_W8(TxPoll, NPQ);
 	}
 }
 

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html