netdev - Re: [PATCH] Allow group ownership of TUN/TAP devices (fwd)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Jun 2007 22:36:54 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jmorris@...ei.org
Cc:	netdev@...r.kernel.org, jdike@...toit.com
Subject: Re: [PATCH] Allow group ownership of TUN/TAP devices (fwd)

From: James Morris <jmorris@...ei.org>
Date: Mon, 18 Jun 2007 12:16:31 -0400 (EDT)

> ---------- Forwarded message ----------
> Date: Mon, 18 Jun 2007 12:05:49 -0400
> From: Jeff Dike <jdike@...toit.com>
> To: maxk@...lcomm.com
> Cc: Guido Guenther <agx@...xcpu.org>, LKML <linux-kernel@...r.kernel.org>,
>     vtun@...ice.satix.net
> Subject: [PATCH] Allow group ownership of TUN/TAP devices
> 
> I recieved from Guido Guenther the patch below to the TUN/TAP driver
> which allows group ownerships to be effective.
> 
> It seems reasonable to me.
> 
> > the attached patches allow tun ownership by group. We found this useful
> > since we can then spawn tapX devices on system boot (via
> > /etc/network/interfaces) which logged on users can then use for their
> > virtual machines.
> >   
> > The first patch is for the kernel, the second one for the tunctl. They
> > shouldn't change existing behaviour and we introduced a new syscall for
> > the group setting. The user now is allowed to send packages if either
> > his euid or his egid matches the one specified via tunctl (via -u or -g
> > respecitvely). If both gid and uid are set via tunctl, both have to
> > match. In case you find these useful, please apply.

This patch looks fine.

I'd like it resubmitted with a proper changelog and signoff, and once
I have that I will thus queue it up for the 2.6.23 merge window.

Thanks!
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html