netdev - Re: [PATCH] net: Make skb_seq_read unmap the last fragment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 23 Jun 2007 23:12:07 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	okir@....de
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: Make skb_seq_read unmap the last fragment

From: Olaf Kirch <okir@....de>
Date: Tue, 19 Jun 2007 09:56:24 +0200

> From: Olaf Kirch <olaf.kirch@...cle.com>
> 
> Make skb_seq_read unmap the last fragment
> 
> Having walked through the entire skbuff, skb_seq_read would leave the
> last fragment mapped.  As a consequence, the unwary caller would leak
> kmaps, and proceed with preempt_count off by one. The only (kind of
> non-intuitive) workaround is to use skb_seq_read_abort.
> 
> This patch makes sure skb_seq_read always unmaps frag_data after having
> cycled through the skb's paged part.
> 
> Signed-off-by: olaf.kirch@...cle.com

Thanks for finding and fixing this bug.

Patch applied, thanks again Olaf.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html