netdev - Re: [PATCH 2.6.21.1] ipconfig: add support for multiple user devs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070626.234512.69020584.davem@davemloft.net>
Date:	Tue, 26 Jun 2007 23:45:12 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	skormilo@...tel.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 2.6.21.1] ipconfig: add support for multiple user devs

From: "Sean Kormilo" <skormilo@...tel.com>
Date: Thu, 17 May 2007 15:16:12 -0400

> Update ipconfig to enable users to specify multiple devices on the kernel commandline
> ip= option. This allows for up-to 4 devices to be specified, with devices separated by 
> a '/' character.  For example, to limit autoconfig requests to eth0 and eth2:
> 	ip=:::::eth0/eth2:DHCP
> 
> This is required in cases where one might want to allow DHCP requests from multiple
> devices, but not necessarily want to broadcast on all ethernet devices that are present 
> in the system.

Hi Sean.  I have no objections to your patch, except that the
4 device limit seems arbitrary.

I would suggest to dynamically kmalloc() up a string buffer after
parsing the option string counting the "/" characters present.

That way there is no limit to the number of devices which can
be specified.

Please make this change and resubmit your patch so that I can
include it, thanks!
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html