netdev - Re: resend [PATCH 3/5 2.6.21] L2TP: PPP over L2TP driver core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 27 Jun 2007 00:20:18 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jchapman@...alix.com
Cc:	netdev@...r.kernel.org
Subject: Re: resend [PATCH 3/5 2.6.21] L2TP: PPP over L2TP driver core

From: James Chapman <jchapman@...alix.com>
Date: Sat, 26 May 2007 18:47:24 +0100

> This driver handles only L2TP data frames; control frames are handled
> by a userspace application. It implements L2TP using the PPPoX socket
> family. There is a PPPoX socket for each L2TP session in an L2TP tunnel.
> PPP data within each session is passed through the kernel's
> PPP subsystem via this driver. Kernel parameters of each socket can be
> read or modified using ioctl() or [gs]etsockopt() calls.
> 
> Signed-off-by: James Chapman <jchapman@...alix.com>

I have no major objections to this patch and would apply
it except for the UDP decapsulation issues.

My suggestion seemingly would work fine here, you could
set the UDP socket callback function pointer when you
set the encap_type.

Please give it a try.

Thanks!
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html