netdev - Re: [PATCH] netpoll: tx lock deadlock fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070627.004028.101596087.davem@davemloft.net>
Date:	Wed, 27 Jun 2007 00:40:28 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...ux-foundation.org
Cc:	netdev@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH] netpoll: tx lock deadlock fix

From: Stephen Hemminger <shemminger@...ux-foundation.org>
Date: Tue, 29 May 2007 17:32:21 -0700

> If sky2 device poll routine is called from netpoll_send_skb, it
> would deadlock. The netpoll_send_skb held the netif_tx_lock, and the
> poll routine could acquire it to clean up skb's. Other drivers
> might use same locking model.
> 
> The driver is correct, netpoll should not introduce more locking problems
> than it causes already. So change the code to drop lock before calling
> poll handler.
> 
> Signed-off-by: Stephen Hemminger <shemminger@...ux.foundation.org>

Patch applied, thanks Stephen.

Once I get this to Linus would you like me to toss it over
to the -stable folks too?

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html