[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <468279FC.3070502@trash.net>
Date: Wed, 27 Jun 2007 16:53:48 +0200
From: Patrick McHardy <kaber@...sh.net>
To: Jarek Poplawski <jarkao2@...pl>
CC: Andrew Morton <akpm@...ux-foundation.org>, netdev@...r.kernel.org,
"bugme-daemon@...nel-bugs.osdl.org"
<bugme-daemon@...nel-bugs.osdl.org>, ranko@...dernet.net
Subject: Re: [Bugme-new] [Bug 8668] New: HTB Deadlock
Jarek Poplawski wrote:
> On Wed, Jun 27, 2007 at 01:44:08PM +0200, Patrick McHardy wrote:
>
>>> BTW, maybe I look at this too short, but is this del_timer()
>>> in gen_kill_estimator() enough? I cannot see nothing against
>>> a timer just running and doing mod_timer() again...
>>>
>> Yes, but nothing bad can happen, the timer will find an empty
>> list and do nothing. It would make more sense to check for
>> an empty list before restarting the timer though.
>>
>>
>> Could you send a patch for that?
>>
>>
>
> Probably I could, but it's your idea!
>
> I look at this just now, and maybe it's enough for asking,
> but definitely not enough for patch. I'll try to check this
> more in the evening, so I could send something tomorrow.
>
> So if it's not only about kindness, feel free to do it
> sooner and I've no doubts - better.
I can take care of it, no problem.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists