lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 28 Jun 2007 11:56:03 +0200 From: Jarek Poplawski <jarkao2@...pl> To: Patrick McHardy <kaber@...sh.net> Cc: David Miller <davem@...emloft.net>, Andrew Morton <akpm@...ux-foundation.org>, netdev@...r.kernel.org, "bugme-daemon\@kernel-bugs\.osdl\.org" <bugme-daemon@...nel-bugs.osdl.org>, ranko@...dernet.net Subject: Re: [NET]: gen_estimator: fix locking and timer related bugs [Re: [Bugme-new] [Bug 8668] New: HTB Deadlock] On Thu, Jun 28, 2007 at 08:54:48AM +0200, Jarek Poplawski wrote: ... > > @@ -215,10 +213,7 @@ void gen_kill_estimator(struct gnet_stats_basic *bstats, > > write_unlock_bh(&est_lock); > > > > kfree(est); > > - killed++; > > } > > - if (killed && elist[idx].list == NULL) > > - del_timer(&elist[idx].timer); > > I think this is needed. The old timer could be pending, while > the gen_new_estimator() is run just after this e.g. in > gen_replace_estimator(). Sorry! I've forgotten there is mod_timer now, so, it's OK! Jarek P. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists