lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 28 Jun 2007 18:46:22 +0200 From: Patrick McHardy <kaber@...sh.net> To: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com> CC: davem@...emloft.net, netdev@...r.kernel.org, jeff@...zik.org, "Kok, Auke-jan H" <auke-jan.h.kok@...el.com>, hadi@...erus.ca Subject: Re: [PATCH 3/3] NET: [SCHED] Qdisc changes and sch_rr added for multiqueue Waskiewicz Jr, Peter P wrote: >>PJ Waskiewicz wrote: >> >> >>>+ >>> static int __init prio_module_init(void) { >>>- return register_qdisc(&prio_qdisc_ops); >>>+ int err; >>>+ err = register_qdisc(&prio_qdisc_ops); >>>+ if (!err) >>>+ err = register_qdisc(&rr_qdisc_ops); >>>+ return err; >>> } >>> >> >>Thats still broken. I'll fix this and some minor cleanness >>issues myself so you don't have to go through another resend. > > > Auke and I just looked at register_qdisc() and this code. Maybe we > haven't had enough coffee yet, but register_qdisc() returns 0 on > success. So if register_qdisc(&prio_qdisc_ops) succeeds, then > rr_qdisc_ops gets registered. I'm curious what is broken with this. Its not error handling. You do: err = register qdisc 1 if (err) return err; err = register qdisc 2 if (err) unregister qdisc 2 return err anyways, I already fixed that and cleaned up prio_classify the way I suggested. Will send shortly. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists