lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 28 Jun 2007 18:50:39 +0200
From: Patrick McHardy <kaber@...sh.net>
To: Patrick McHardy <kaber@...sh.net>
CC: PJ Waskiewicz <peter.p.waskiewicz.jr@...el.com>,
davem@...emloft.net, netdev@...r.kernel.org, jeff@...zik.org,
auke-jan.h.kok@...el.com, hadi@...erus.ca
Subject: Re: [PATCH 3/3] NET: [SCHED] Qdisc changes and sch_rr added for multiqueue
Patrick McHardy wrote:
> PJ Waskiewicz wrote:
>
>> +
>> static int __init prio_module_init(void)
>> {
>> - return register_qdisc(&prio_qdisc_ops);
>> + int err;
>> + err = register_qdisc(&prio_qdisc_ops);
>> + if (!err)
>> + err = register_qdisc(&rr_qdisc_ops);
>> + return err;
>> }
>>
>
>
> Thats still broken. I'll fix this and some minor cleanness issues myself so
> you don't have to go through another resend.
Here it is, fixed error handling and cleaned up prio_classify.
There are still too many ifdefs in there for my taste, and I'm
wondering whether the NET_SCH_MULTIQUEUE option should really
be NETDEVICES_MULTIQUEUE. That would allow to move the #ifdefs
to netif_subqueue_stopped and keep the qdiscs clean.
I can send a patch for that on top of your patches.
View attachment "x" of type "text/plain" (8183 bytes)
Powered by blists - more mailing lists