lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 28 Jun 2007 19:13:07 +0200 From: Patrick McHardy <kaber@...sh.net> To: PJ Waskiewicz <peter.p.waskiewicz.jr@...el.com> CC: davem@...emloft.net, netdev@...r.kernel.org, jeff@...zik.org, auke-jan.h.kok@...el.com, hadi@...erus.ca Subject: Re: [PATCH 3/3] NET: [SCHED] Qdisc changes and sch_rr added for multiqueue PJ Waskiewicz wrote: > +#ifdef CONFIG_NET_SCH_MULTIQUEUE > + if (q->mq) > + skb->queue_mapping = > + q->prio2band[band&TC_PRIO_MAX]; > + else > + skb->queue_mapping = 0; > +#endif Setting it to zero here is wrong, consider: root qdisc: prio multiqueue child qdisc: prio non-multiqueue The top-level qdisc will set it, the child qdisc will unset it again. When multiqueue is inactive it should not touch it. I'll fix that as well. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists