netdev - Re: e1000: backport ich9 support from 7.5.5 ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c0a09e5c0706291657kd5e4baawb113a17ca5ab2191@mail.gmail.com>
Date:	Fri, 29 Jun 2007 16:57:46 -0700
From:	"Andrew Grover" <andy.grover@...il.com>
To:	"Jeff Garzik" <jeff@...zik.org>
Cc:	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Kok, Auke" <auke-jan.h.kok@...el.com>,
	"Jason Lunz" <lunz@...lexsecurity.com>,
	"Mark McLoughlin" <markmc@...hat.com>,
	e1000-devel@...ts.sourceforge.net, netdev@...r.kernel.org
Subject: Re: e1000: backport ich9 support from 7.5.5 ?

On 6/29/07, Jeff Garzik <jeff@...zik.org> wrote:
> Given past history with duplicate drivers and the problems that they
> cause -- I know, I've caused some of those problems :( -- I strongly
> recommend against when it can be avoided.
>
> Leaving e1000 with current hardware, and a new e1001 for newer hardware
> should be easier to manage for all involved, without the headaches that
> duplicate drivers cause.
>
> An "e1001" approach also means we have a much greater chance of
> encouraging Intel down the path of clean driver-ness.

When I was at Intel, I heard a lot of "the linux community won't let
us split the driver". "Oh well, guess we gotta keep lugging around all
the old crap." So it was a (perhaps misunderstood) desire to make you
guys happy that led to e1000 turning into a monster.

I think making e1000new ICH9-and-newer isn't really the best place to
split it. The Windows e1000 driver got split on the PCI->PCIe
transition, something that clearly delineated what nics one driver
supported, and the other. There's no real technical reason for
splitting now other than "this was when e1000old collapsed under its
own weight".

The PCIe adapters are also the first ones to support multiple queues
IIRC, maybe that would be an another actual technical reason to split
it there?

-- Andy
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html