netdev - Re: [PATCH 2.6.22 2/4]S2IO: Removing MSI support from the driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4688ECF8.9000204@garzik.org>
Date:	Mon, 02 Jul 2007 08:18:00 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Veena Parat <Veena.Parat@...erion.com>
CC:	netdev@...r.kernel.org, Leonid.Grossman@...erion.com,
	ramkrishna.vepa@...erion.com, santosh.rastapur@...erion.com,
	Sivakumar.Subramani@...erion.com, sreenivasa.honnur@...erion.com,
	alicia.pena@...erion.com, sriram.rapuru@...erion.com
Subject: Re: [PATCH 2.6.22 2/4]S2IO: Removing MSI support from the driver

Veena Parat wrote:
> 1.Removed MSI support from driver - unused feature
> 2.Removed pci_request_regions call to allocate bar2 as it is not used in driver
> 3.Removed pci_release_regions since pci_request_regions is not done

This is wrong.  pci_request_regions() grabs all the regions for the 
associated PCI device, which is the desired behavior.

Using request_mem_region() is not what you want to do for PCI devices.


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html