netdev - Re: Handling set_mac_address in set_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 02 Jul 2007 14:20:16 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Jeff Garzik <jeff@...zik.org>
CC:	Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: Handling set_mac_address in set_rx_mode

Jeff Garzik wrote:
> Patrick McHardy wrote:
> 
>> While adding support for secondary unicast addresses to 8021q and
>> macvlan, I've tried keeping dev->dev_addr as global address on
>> dev->uc_list and have drivers skip them to avoid having all
>> dev_unicast_add users implement a state machine like this:
> 
> 
> [...]
> 
> Something that is not entirely clear to me...  This has zero impact on
> existing drivers, right?


Yes, since the set_rx_mode hook is new anyway this would only
affect drivers offering it (which is none so far). But this
idea turned not to be so good anyways, without the
set_mac_address callback the driver can't validate the new
address.

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html