netdev - Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4689062A.8080809@linux.intel.com>
Date:	Mon, 02 Jul 2007 07:05:30 -0700
From:	Arjan van de Ven <arjan@...ux.intel.com>
To:	Jeff Garzik <jeff@...zik.org>
CC:	Ayyappan Veeraiyan <ayyappan.veeraiyan@...el.com>,
	netdev@...r.kernel.org, auke-jan.h.kok@...el.com,
	akpm@...ux-foundation.org
Subject: Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based
 PCI	Express adapters...

 >> +    u32 alloc_rx_buff_failed;
>> +    struct {
>> +        unsigned int rx_csum_enabled    :1;
>> +        unsigned int msi_capable    :1;
>> +        unsigned int msi_enabled    :1;
>> +        unsigned int msix_capable    :1;
>> +        unsigned int msix_enabled    :1;
>> +        unsigned int imir_enabled    :1;
>> +        unsigned int in_netpoll        :1;
>> +    } flags;
> 
> always avoid bitfields.  They generate horrible code, and endian 
> problems abound (though no endian problems are apparent here).

they generate no worse code than open coding the checks for these 
feature flags...
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html