lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 02 Jul 2007 21:40:36 -0700 (PDT) From: David Miller <davem@...emloft.net> To: akpm@...ux-foundation.org Cc: ecashin@...aid.com, linux-kernel@...r.kernel.org, greg@...ah.com, netdev@...r.kernel.org Subject: Re: [PATCH 07/12] use a dynamic pool of sk_buffs to keep up with fast targets From: Andrew Morton <akpm@...ux-foundation.org> Date: Mon, 2 Jul 2007 21:36:36 -0700 > My initial thought is that if there is a legitimate need for this > new capability then it should be made available to other parts of > the kernel rather than being private to the AEO driver. Absolutely. We even used to have something like this on a per-cpu basis but using generic SLAB is so much better for caching and NUMA that we got rid of that. Every sk_buff private "quicklist" pool implementation you see should essentially be NAK'd from the get go, it's meaningless and if it's really needed one should investigate why SKB allocations become such a problem instead of papering over the issue. :-) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists