[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20070702.221009.56977806.davem@davemloft.net>
Date: Mon, 02 Jul 2007 22:10:09 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: ilpo.jarvinen@...sinki.fi
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH tcp-2.6 3/3] [TCP]: Move sack_ok access to obviously
named funcs & cleanup
From: "Ilpo_Järvinen" <ilpo.jarvinen@...sinki.fi>
Date: Fri, 15 Jun 2007 14:10:30 +0300
> From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <ilpo.jarvinen@...sinki.fi>
>
> Previously code had IsReno/IsFack defined as macros that were
> local to tcp_input.c though sack_ok field has users elsewhere
> too for the same purpose. This changes them to static inlines as
> preferred according the current coding style and unifies the
> access to sack_ok across multiple files. Magic bitops of sack_ok
> for FACK and DSACK are also abstracted to functions with
> appropriate names.
>
> Note:
> - One sack_ok = 1 remains but that's self explanary, i.e., it
> enables sack
> - Couple of !IsReno cases are changed to tcp_is_sack
> - There were no users for IsDSack => I dropped it
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>
Also applied to tcp-2.6, thanks a lot!
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists