lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 03 Jul 2007 14:56:40 +0200 From: Patrick McHardy <kaber@...sh.net> To: Michael Buesch <mb@...sch.de> CC: Michael Wu <flamingice@...rmilk.net>, Jiri Benc <jbenc@...e.cz>, John Linville <linville@...driver.com>, linux-wireless@...r.kernel.org, Linux Netdev List <netdev@...r.kernel.org> Subject: Re: [PATCH RFC] mac80211: Make stop_queues() usable Michael Buesch wrote: > On Tuesday 03 July 2007 14:31:31 Patrick McHardy wrote: > >>The wireless multiqueue handling should be replaced by the generic >>implementation in net-2.6.23 (using prio, seperating out the wme >>classifier and killing the broken scheduler). You don't need to >>stop individual subqueues for a full shutdown with that implementation, >>you can just stop the global queue. Not sure if that really helps for >>this case though since I didn't look to deep into this code. > > > That's exactly what I want. Stop the "global queue". > As there is no "global queue" in mac80211, I need to stop every queue. I could help you take care of the scheduler part if someone else takes care of the drivers and mac80211. Roughly what they need to do is: - use alloc_netdev_mq instead of alloc_netdev - use netif_{start,stop,wake}_subqueue instead of the wireless equivalents - when all subqueues are stopped the global queue should be stopped in the usual way (netif_stop_queue), when at least one is active the global queue should be woken - use skb->queue_mapping instead of skb->priority to get the HW queue The scheduler part mainly consists of offering a clean way to install a different default qdisc than pfifo_fast and adding a default classifier. I'm presuming the wme classifier would also be useful for other (non-mac80211) wireless drivers that offer multiple queues, so it should probably be completely seperated from mac80211 and moved to net/sched. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists