netdev - Re: [PATCH] [TCP]: Fix logic breakage due to DSACK separation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070703.142554.133910878.davem@davemloft.net>
Date:	Tue, 03 Jul 2007 14:25:54 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ilpo.jarvinen@...sinki.fi
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] [TCP]: Fix logic breakage due to DSACK separation

From: "Ilpo_Järvinen" <ilpo.jarvinen@...sinki.fi>
Date: Tue, 3 Jul 2007 13:52:35 +0300 (EEST)

> 1. fack_count in skb (your proposal months ago)
>    + Trivial arithmetics, no walking necessary to find it (ever)
>    - Very expensive in storage wise (like you have stated earlier)

We have a 4-byte hole in sk_buff currently on 64-bit
(right after the 'iif' member), however it's hard to
crib those 4-bytes into the ->cb[] area where we need
it since the cb needs to be 8-byte aligned.

I'm not against making some space if it makes things
exceedingly easier.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html