netdev - Re: [PATCH net-2.6.23 take2] UDP: Cleanup UDP encapsulation code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200707051951.03619@auguste.remlab.net>
Date:	Thu, 5 Jul 2007 19:50:59 +0300
From:	Rémi Denis-Courmont <rdenis@...phalempin.com>
To:	netdev@...r.kernel.org
Cc:	remi.denis-courmont@...ia.com
Subject: Re: [PATCH net-2.6.23 take2] UDP: Cleanup UDP encapsulation code

Le jeudi 5 juillet 2007, vous avez écrit :
> James Chapman wrote:
> > This cleanup fell out after adding L2TP support where a new
> > encap_rcv funcptr was added to struct udp_sock. Have XFRM use the
> > new encap_rcv funcptr, which allows us to move the XFRM encap code
> > from udp.c into xfrm4_input.c.
> >
> > Make xfrm4_rcv_encap() static since it is no longer called
> > externally.
> >
> > Signed-off-by: James Chapman <jchapman@...alix.com>
> >
> > ---
> > Tested with L2TP and L2TP/IPsec.
> >
> > Update after comments from Patrick. Fix encapsulated transport mode
> > case and remove stupid file history comment change.
>
> Looks good, thanks.

By the way, couldn't encap_type be remove altogether (using two slightly 
different callbacks for ESP) from udp_sock?

-- 
Rémi Denis-Courmont

Download attachment "signature.asc " of type "application/pgp-signature" (198 bytes)