netdev - Re: [RFC 2/2] shrink size of scatterlist on common i386/x86-64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 05 Jul 2007 16:32:45 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	Stephen Hemminger <shemminger@...ux-foundation.org>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [RFC 2/2] shrink size of scatterlist on common i386/x86-64

 > --- a/include/asm-i386/scatterlist.h	2007-07-05 14:37:11.000000000 -0700
 > +++ b/include/asm-i386/scatterlist.h	2007-07-05 15:44:51.000000000 -0700
 > @@ -5,9 +5,9 @@
 >  
 >  struct scatterlist {
 >      struct page		*page;
 > -    unsigned int	offset;
 >      dma_addr_t		dma_address;
 > -    unsigned int	length;
 > +    u16			offset;
 > +    u16			length;
 >  };

Actually this struct layout could be even better, since pointers are
32 bits but dma_addr_t may be 64 bits... having

struct scatterlist {
	dma_addr_t	dma_address;
	struct page    *page;
	u16		offset;
	u16		length;
};

would allow struct scatterlist to be 16 bytes.  Seems like a good thing...

 - R.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html