netdev - Re: [PATCH v2] tg3: Tx availability fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1183727680.5155.12.camel@localhost>
Date:	Fri, 06 Jul 2007 09:14:40 -0400
From:	jamal <hadi@...erus.ca>
To:	Matt Carlson <mcarlson@...adcom.com>
Cc:	Robert Olsson <Robert.Olsson@...a.slu.se>,
	Evgeniy Polyakov <johnpol@....mipt.ru>,
	Krishna Kumar2 <krkumar2@...ibm.com>,
	Gagan Arneja <gaagaan@...il.com>, netdev@...r.kernel.org,
	Rick Jones <rick.jones2@...com>,
	Sridhar Samudrala <sri@...ibm.com>,
	David Miller <davem@...emloft.net>,
	Jeff Garzik <jeff@...zik.org>,
	Michael Chan <mchan@...adcom.com>
Subject: Re: [PATCH v2] tg3: Tx availability fix

Matt,

I have applied both changes (and updated the git tree) with a small
caveat on the second patch:

On Thu, 2007-05-07 at 17:59 -0700, Matt Carlson wrote:

> The last change makes sure that new xmit_win values, as assigned by the
> transmit queue wake code, will not be drastically larger than the value
> set during initialization.

I have left out the above change i.e i kept it as
dev->xmit_win = tp->tx_pending

If you dont mind lets keep it that way for now so we dont introduce any
new variables. i.e. thats how i have been testing and collecting
results. 
If you run some tests and come up with better results by using a /4 i
would be more than happy to add it back.

Thanks very much for all your efforts - Broadcom rocks.

cheers,
jamal

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html