netdev - Re: [PATCH] atl1: remove write-only var in tx handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 6 Jul 2007 10:28:19 -0500
From:	Jay Cliburn <jcliburn@...il.com>
To:	Alexey Dobriyan <adobriyan@...ru>
Cc:	jgarzik@...ox.com, netdev@...r.kernel.org, csnook@...hat.com
Subject: Re: [PATCH] atl1: remove write-only var in tx handler

On Fri, 6 Jul 2007 19:05:25 +0400
Alexey Dobriyan <adobriyan@...ru> wrote:

> Signed-off-by: Alexey Dobriyan <adobriyan@...ru>
> ---
> 
>  drivers/net/atl1/atl1_main.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> --- a/drivers/net/atl1/atl1_main.c
> +++ b/drivers/net/atl1/atl1_main.c
> @@ -634,14 +634,13 @@ static void atl1_intr_tx(struct atl1_adapter
> *adapter) struct atl1_buffer *buffer_info;
>  	u16 sw_tpd_next_to_clean;
>  	u16 cmb_tpd_next_to_clean;
> -	u8 update = 0;
>  
>  	sw_tpd_next_to_clean = atomic_read(&tpd_ring->next_to_clean);
>  	cmb_tpd_next_to_clean =
> le16_to_cpu(adapter->cmb.cmb->tpd_cons_idx); 
>  	while (cmb_tpd_next_to_clean != sw_tpd_next_to_clean) {
>  		struct tx_packet_desc *tpd;
> -		update = 1;
> +
>  		tpd = ATL1_TPD_DESC(tpd_ring, sw_tpd_next_to_clean);
>  		buffer_info =
> &tpd_ring->buffer_info[sw_tpd_next_to_clean]; if (buffer_info->dma) {
> 
Acked-by: Jay Cliburn <jacliburn@...lsouth.net>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html